fix: advanced marker position can be null#903
Open
LeLunZ wants to merge 3 commits intogooglemaps:mainfrom
Open
fix: advanced marker position can be null#903LeLunZ wants to merge 3 commits intogooglemaps:mainfrom
LeLunZ wants to merge 3 commits intogooglemaps:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
@LeLunZ Thanks for the work! I would like to integrate this for the next release, are you still up to continue working on this or should I just take it from here? |
Author
|
@usefulthink I think its better if you continue with it. I am currently occupied |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #902 🦕
Currently there is still a problem with the tests.
As google.maps.Markers and google.maps.marker.AdvancedMarkerElement are inconsistent in their way of handling the position.
.getPositionon google.maps.Marker returns a LatLng(lat=0, lng=0) even if no position was provided.While google.maps.marker.AdvancedMarkerElement .position really is
null.If a fix like the one provided in the PR would be accepted, the tests needs to be changed because of the inconsistency.